Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: replace IsConstructCall functions with lamda #12384

Closed
wants to merge 1 commit into from
Closed

src: replace IsConstructCall functions with lamda #12384

wants to merge 1 commit into from
+7 −18

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 13, 2017

I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lamda.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. labels Apr 13, 2017
@danbev
Copy link
Contributor Author

danbev commented Apr 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/7369/

bnoordhuis
bnoordhuis approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits. Typo in commit log: s/lamda/lambda/

src/cares_wrap.cc Outdated
@@ -1399,24 +1384,27 @@ static void Initialize(Local<Object> target,
target->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "AI_V4MAPPED"),
Integer::New(env->isolate(), AI_V4MAPPED));

auto isConstructCall = [](const FunctionCallbackInfo<Value>& args) {
CHECK(args.IsConstructCall());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two spaces of indent and call the variable is_construct_call (or is_construct_call_callback to indicate it's a function pointer.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah again, must remember to not use camelcase 😞 Thanks!

@danbev
Copy link
Contributor Author

danbev commented Apr 13, 2017

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/7372/

@danbev
src: replace IsConstructCall functions with lambda
a440ec8 
I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lambda.
@danbev
Copy link
Contributor Author

danbev commented Apr 15, 2017

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/7415/

@addaleax
Copy link
Member

Landed in b280363

@addaleax addaleax closed this Apr 15, 2017
addaleax pushed a commit that referenced this pull request Apr 15, 2017
@danbev @addaleax
src: replace IsConstructCall functions with lambda
b280363 
I noticed that there are three static functions that only check if
args is a construct call. This commit suggests replacing them and
them with a lambda.

PR-URL: #12384
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev danbev deleted the cares_wrap-lamda branch April 18, 2017 12:32
@AndreasMadsen AndreasMadsen mentioned this pull request May 8, 2017
Closed
4 tasks
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@gibfahn
Copy link
Member

gibfahn commented Jun 18, 2017

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @addaleax @gibfahn @bnoordhuis @jasnell @cjihrig @nodejs-github-bot